Fix current section update issues #6845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible to methods like loadCode to be holding onto invalid/no longer used current section list references
APickledWalrus
added
bug
sovdeeth
approved these changes
Jul 1, 2024
ShaneBeee
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an important issue where, when loading a new section, Skript may fail to remove the newly-loaded section from the current sections list. This is caused by the methods holding onto an unsafe. This issue was exposed by #6699 which makes changes to the list being referenced. However, even before this PR, this was unsafe as the method
ParserInstance#setCurrentSectionsexists (meaning any addons changing the list reference could introduce issues).I have resolved this issue by creating and setting a copy of the current sections list, and then setting it back to the original list when it is time to exit.
Target Minecraft Versions: any
Requirements: none
*Related Issues: