Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExprName InventoryView IncompatibleClassChangeError #6874

Merged

Conversation

APickledWalrus
Copy link
Member

@APickledWalrus APickledWalrus commented Jul 6, 2024

Description

This fixes an issue where name of <inventory> does not work on versions older than 1.21. This is caused by InventoryView now being an interface on 1.21 rather than an abstract class.


Target Minecraft Versions: any
Requirements: none
Related Issues:

@APickledWalrus APickledWalrus added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jul 6, 2024
@APickledWalrus APickledWalrus added the 2.9 Targeting a 2.9.X version release label Jul 6, 2024
@APickledWalrus

This comment was marked as resolved.

@APickledWalrus APickledWalrus marked this pull request as draft July 7, 2024 16:53
@APickledWalrus APickledWalrus marked this pull request as ready for review July 7, 2024 17:15
Code is now tested...
@APickledWalrus APickledWalrus merged commit 94aa3e5 into SkriptLang:dev/feature Jul 10, 2024
5 checks passed
@APickledWalrus APickledWalrus deleted the patch/inventory-title-fix branch July 10, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9 Targeting a 2.9.X version release bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants