Fix Incorrect BlockValues#isDefault #6876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
bug
ShaneBeee
approved these changes
Jul 6, 2024
AyhamAl-Ali
approved these changes
Jul 6, 2024
Moderocky
approved these changes
Jul 7, 2024
sovdeeth
approved these changes
Jul 7, 2024
sovdeeth
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a small but major mistake I made with the ItemType changes in #6798. I added a new BlockValues getter for Materials, but I accidentally marked the returned instance as NOT being default (i.e. having special block values). Of course, this is wrong because the BlockData used is freshly created. This caused many comparison issues as items without specific block values were considered as having them.
Target Minecraft Versions: any
Requirements: none
Related Issues: