Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new spawn reasons for 1.21 #6906

Merged
merged 8 commits into from
Aug 1, 2024

Conversation

EquipableMC
Copy link
Contributor

@EquipableMC EquipableMC commented Jul 16, 2024

Description

This simply adds support for ominous item spawner for spawn reasons, which was approved very recently in #10897 in paper.

Edit:
This also adds support for potion effects, which was approved the day before paper 1.21 became stable in #11102


Target Minecraft Versions: 1.21
Requirements: 1.21 paper
Related Issues: image

@sovdeeth sovdeeth added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. enhancement Feature request, an issue about something that could be improved, or a PR improving something. labels Jul 16, 2024
Copy link
Collaborator

@TheLimeGlass TheLimeGlass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now also potion effect as a spawn reason as of Yesterday, the day before Paper released 1.21. Can that be added here?

@EquipableMC
Copy link
Contributor Author

There is now also potion effect as a spawn reason as of Yesterday, the day before Paper released 1.21. Can that be added here?

yeah, I'll add it now

@EquipableMC EquipableMC changed the title Adds ominous item spawner support Adds new spawn reasons for 1.21 Jul 21, 2024
@APickledWalrus
Copy link
Member

might be worth testing how this interacts with like:

set {_var} to some potion effect
if {_var} is a potion effect:

@sovdeeth sovdeeth added the 2.9 Targeting a 2.9.X version release label Jul 31, 2024
@EquipableMC
Copy link
Contributor Author

might be worth testing how this interacts with like:

set {_var} to some potion effect
if {_var} is a potion effect:

oh yeah good call let me test now

@APickledWalrus
Copy link
Member

some quick testing indicates that for:

set {_var} to some potion effect
if {_var} is a potion effect:

it works fine for a potion effect, not for potion effect. i don't imagine this would have a major impact (and this is already likely an issue with other types).

@APickledWalrus APickledWalrus merged commit ad1a492 into SkriptLang:dev/patch Aug 1, 2024
5 checks passed
@EquipableMC EquipableMC deleted the lang-file-fix branch August 1, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9 Targeting a 2.9.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants