Apply new conventions to lang package #6918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions, and use try-with-resources for loggers
sovdeeth
added
the
enhancement
APickledWalrus
requested changes
Jul 24, 2024
src/main/java/ch/njol/skript/lang/function/ExprFunctionCall.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/lang/function/SimpleJavaFunction.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Patrick Miller <[email protected]>
APickledWalrus
approved these changes
Jul 24, 2024
sovdeeth
added
the
feature-ready
APickledWalrus
added a commit
to potaromc/Skript
that referenced
this pull request
Jul 27, 2024
This reverts commit 2f4232d.
Prorickey
pushed a commit
to Prorickey/Skript
that referenced
this pull request
Aug 3, 2024
* Update lang package to new annotation conventions, new warning conventions, and use try-with-resources for loggers * Apply suggestions from code review Co-authored-by: Patrick Miller <[email protected]> * Requested changes --------- Co-authored-by: Moderocky <[email protected]> Co-authored-by: Patrick Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update lang package to new annotation conventions, new warning conventions, and use try-with-resources for loggers.
This should help prevent new contributions from using outdated annotations.
I will also add this one to the git ignore file once merged.
Target Minecraft Versions: any
Requirements: none
Related Issues: none