Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix in german.lang and adds dutch.lang #6942

Merged
merged 62 commits into from
Aug 31, 2024

Conversation

mugu2006
Copy link
Contributor

Added german translation for "Nightly Build" message, it was previously still english

Added dutch.lang, have seen a lot of dutch people using Skript so thought to add it.

src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
@Efnilite
Copy link
Member

gute Arbeit 👍

Copy link
Contributor Author

@mugu2006 mugu2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes in sentence structure/grammar, with help of Efnilite

Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for one other native dutch speaker and one other native german speaker for review!

@sovdeeth sovdeeth added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. enhancement Feature request, an issue about something that could be improved, or a PR improving something. 2.9 Targeting a 2.9.X version release labels Jul 31, 2024
@sovdeeth sovdeeth changed the base branch from master to dev/patch July 31, 2024 06:10
Copy link
Contributor

@Mwexim Mwexim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are very nitpicky comments but I feel a translation loses its purpose if it's not 100% sound. It's possible that I missed some things.

Your translation sometimes lacks consistency. I tried to fix it where possible. Notably, make a decision between 'lijn' or 'regel' to denote 'line', personally I'd pick the latter.

This is coming from a native Dutch speaker.

src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Show resolved Hide resolved
src/main/resources/lang/dutch.lang Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
src/main/resources/lang/dutch.lang Outdated Show resolved Hide resolved
@Efnilite
Copy link
Member

Efnilite commented Aug 2, 2024

took another look at it

Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just putting a blocking request here until the changes from the other two reviewers are addressed.

@mugu2006
Copy link
Contributor Author

No worries, was busy dealing with some personal issues, will have a look now

@Moderocky Moderocky requested a review from Mwexim August 20, 2024 07:51
@Moderocky Moderocky added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Aug 20, 2024
mugu2006 and others added 27 commits August 23, 2024 12:50
@Moderocky Moderocky merged commit 9a4c0ee into SkriptLang:dev/patch Aug 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9 Targeting a 2.9.X version release bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants