Temporary fix for plural endings error. #6982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
approved these changes
Aug 18, 2024
|
So the test uses They all seem to be compounds of |
Moderocky
added
bug
sovdeeth
requested changes
Aug 31, 2024
| /** | ||
| * @param s trimmed string | ||
| * @param word trimmed string | ||
| * @return Pair of singular string + boolean whether it was plural | ||
| */ | ||
| @SuppressWarnings("null") |
There was a problem hiding this comment.
it'd be nice to move this to a noinspection if feasible
Co-authored-by: sovdee <[email protected]>
sovdeeth
approved these changes
Aug 31, 2024
Moderocky
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some plural word endings are incorrectly detected, e.g.
-us->-ipicks up "gui" as being a plural of (the well known word) "guus", and-fe->-vespicks up "objectives" as being a plural of "objectife".This PR patches these two cases for now (by adding an alternative first) and I've moved to a queue and a helper class rather than a fixed-size array to make the follow-up API a little easier: you should be able to add stuff to the beginning or end of the queue without trouble.
I'd like to follow up with a proper system for doing this a little more effectively, and the ability for addons to fix any of their own problematic cases by registering plural overrides.
That's probably out of scope for a patch version so it will likely be a 2.10 feature, maybe using some registrations stuff?
Target Minecraft Versions: any
Requirements: none
Related Issues: fixes #6981, fixes #5879