Update ExprHoverList for 1.21+ #6988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
changed the title
sovdeeth
added
bug
Moderocky
requested changes
Aug 20, 2024
UnderscoreTud
requested changes
Aug 20, 2024
|
@UnderscoreTud the event can only be called asynchronously, but it seems that this causes it to not complete the objectives as the event is called after the tests have completed, therefore saying that no objectives have been completed, despite the fact that they do actually complete. i've also had to do some trickery to make sure it recognizes it as the current test. any ideas on how to fix this? |
Moderocky
approved these changes
Aug 27, 2024
sovdeeth
approved these changes
Aug 27, 2024
Co-authored-by: sovdee <[email protected]>
|
before this is merged, #6988 (comment) needs to be addressed by someone who actually knows what they're doing |
|
I think it'd be better to simply remove the tests if we can't find a quick fix rather than put this off till 2.9.3 |
# Conflicts: # src/test/skript/junit/ExprHoverList.sk
APickledWalrus
approved these changes
Sep 1, 2024
UnderscoreTud
approved these changes
Sep 1, 2024
Moderocky
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6974 while maintaining backwards compatibility. Tested on 1.20.5 and 1.21.1 with the code used in the original issue. Not sure how I would add tests for this, please lmk for ideas.
Target Minecraft Versions: any
Requirements: none
Related Issues: #6974