Fix NoSuchMethodError with play sound effect on 1.18 #7016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
bug
Moderocky
approved these changes
Aug 31, 2024
APickledWalrus
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
on 1.18 the entity emitters pr causes playsound to emit:
java.lang.NoSuchMethodError: 'void org.bukkit.entity.Player.playSound(org.bukkit.entity.Entity, java.lang.String, org.bukkit.SoundCategory, float, float)'This changes the required methodExists check to look for
playSound(org.bukkit.entity.Entity, java.lang.String, org.bukkit.SoundCategory, float, float)instead ofplaySound(org.bukkit.entity.Entity, org.bukkit.Sound, org.bukkit.SoundCategory, float, float), which causes the functionality to be 1.19+ but fixes the bug for now.Further refactoring should be done to the logic here to allow 1.18 to work with entity emitters too, but it's more involved than I think I can do in a day.
Target Minecraft Versions: any
Requirements: none
Related Issues: none