-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commands Rework #7032
Draft
sovdeeth
wants to merge
15
commits into
dev/feature
Choose a base branch
from
feature/commands-rework
base: dev/feature
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commands Rework #7032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i haven't touched this in months but it looks like a solid base, need to get it updated to master
Pulls cooldown logic out of ScriptCommand and into its own event. Allows varied end dates for each player to give users more control without destroying the usefulness of lastUsage.
I hope I'm not making a bunch of poor choices
sovdeeth
added
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
feature
Pull request adding a new feature.
parent
A pull request for a major feature or change that requires multiple PRs to complete.
labels
Sep 3, 2024
* initial changes to allow pr creation * cleanup 1
# Conflicts: # src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java # src/main/java/ch/njol/skript/effects/EffCancelCooldown.java # src/main/java/ch/njol/skript/expressions/ExprAllCommands.java # src/main/java/ch/njol/skript/expressions/ExprCmdCooldownInfo.java # src/main/java/ch/njol/skript/expressions/ExprCommand.java # src/main/java/org/skriptlang/skript/commands/elements/ExprArgument.java # src/main/java/org/skriptlang/skript/commands/elements/ExprCommandInfo.java # src/main/java/org/skriptlang/skript/commands/elements/StructCommand.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
feature
Pull request adding a new feature.
parent
A pull request for a major feature or change that requires multiple PRs to complete.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The long-awaited command rework! This PR serves as a tracker for work done, and individual command rework PRs should be merged into this branch instead of directly to dev/feature.
Existing work:
Prior to this PR, some work has already been done towards the command rework.
Work to be done:
This PR is in a draft as details have not yet been hammered out, but the current goals are to provide the following:
These are not final and are purposely slightly vague, as more discussion needs to occur before deciding on exact courses. This PR will be updated semi-regularly to reflect the current state of affairs. The following is a rough idea of what these goals would look like in a final form, though, again, details and implementation are subject to change. This, too, will be updated semi-regularly.
Feedback and opinions welcome as comments on this PR, in the skriptlang-development channel on the skUnity discord, or in the SkriptLang testing discord.
Target Minecraft Versions: any
Requirements: none
Related Issues: #6934, #6560, #4830, #3894, #3642, #3408, #2809, #2155, #1197, closes #3408, closes #2809