Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wolf Variants #7041

Open
wants to merge 16 commits into
base: dev/feature
Choose a base branch
from
Open

Wolf Variants #7041

wants to merge 16 commits into from

Conversation

TheAbsolutionism
Copy link

@TheAbsolutionism TheAbsolutionism commented Sep 6, 2024 •
edited
Loading

Description

This PR aims to add wolf variants

Target Minecraft Versions: 1.21+
Requirements: none
Related Issues: #6923

@TheAbsolutionism
Fixxy Fix
697acd6 
Fixed, inability to operate on MC versions not containing 'Wolf.Variant'
Added, required data/types into lang
Added, test to spawn variant wolves
Added, spawning a wolf without a provided variant, will  choose a random one (Like Cats)
@TheLimeGlass TheLimeGlass added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Sep 7, 2024
sovdeeth
sovdeeth requested changes Sep 13, 2024
View reviewed changes
src/main/java/ch/njol/skript/entity/WolfData.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/entity/WolfData.java Outdated Show resolved Hide resolved
src/test/skript/tests/syntaxes/effects/EffSpawn.sk Outdated Show resolved Hide resolved
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Moderocky Moderocky Moderocky approved these changes

@cheeezburga cheeezburga cheeezburga approved these changes

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheAbsolutionism @sovdeeth @Moderocky @cheeezburga @TheLimeGlass