Update ExprTime #7082
Merged
Update ExprTime #7082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
added
the
bug
Asleeepp
suggested changes
Sep 15, 2024
Asleeepp
approved these changes
Sep 15, 2024
Comment on lines
90
to
114
| long ticks = 0; | ||
| if (time instanceof Time) { | ||
| if (mode != ChangeMode.SET) { | ||
| ticks = ((Time) time).getTicks() - TIME_TO_TIMESPAN_OFFSET; // allows for using "add 2:00" without going to new day | ||
| } else { | ||
| ticks = ((Time) time).getTicks(); | ||
| } | ||
| } else if (time instanceof Timespan) { | ||
| ticks = ((Timespan) time).getAs(Timespan.TimePeriod.TICK); | ||
| } else if (time instanceof Timeperiod) { | ||
| ticks = ((Timeperiod) time).start; | ||
| } | ||
|
|
||
| for (World world : worlds) { | ||
| switch (mode) { | ||
| case ADD: | ||
| world.setTime(world.getTime() + ticks); | ||
| break; | ||
| case REMOVE: | ||
| world.setTime(world.getTime() - ticks); | ||
| break; | ||
| case SET: | ||
| world.setTime(ticks); | ||
| break; | ||
| } |
There was a problem hiding this comment.
you could add the for loop to a helper method, and call the method in each of the instanceof checks, this avoids the need for the ticks variable (except for in time instanceof Time)
of course you dont have to do this, i just think it'll look a little neater
There was a problem hiding this comment.
good idea but i think this is easier to understand. if the team thinks your approach is better, i'll change it
Fusezion
suggested changes
Sep 15, 2024
Moderocky
requested changes
Sep 16, 2024
Moderocky
approved these changes
Sep 16, 2024
sovdeeth
approved these changes
Sep 19, 2024
sovdeeth
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #7081.
minecraft <timespan>syntax, as not using this to update the world's time results in confusing behaviour. Also explains that removing time from a world will move the clock forward a day.Target Minecraft Versions: any
Requirements: none
Related Issues: #7081