FurnaceEvents, Expressions #7093
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
requested changes
Sep 19, 2024
Comment on lines
126
to
128
| if (!explicitlyBlock && event instanceof FurnaceStartSmeltEvent startEvent) { | ||
| return new Timespan(Timespan.TimePeriod.TICK, startEvent.getTotalCookTime()); | ||
| } else { |
There was a problem hiding this comment.
this concerns me, since time of event-block and time might return different values.
There was a problem hiding this comment.
Should I test that out or do you have something in mind?
There was a problem hiding this comment.
you should definitely test that
cheeezburga
added
the
enhancement
…sm/SkriptTest into dev/FurnaceEvents
Efnilite
suggested changes
Sep 20, 2024
src/test/java/org/skriptlang/skript/test/tests/syntaxes/events/EvtFurnaceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/skriptlang/skript/test/tests/syntaxes/events/EvtFurnaceTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add two of of the missing furnace events, and a rewrite of old expressions plus addition of new expressions
Target Minecraft Versions: any
Requirements: none
Related Issues: none