Eff + Cond Lidded #7094
Open
Eff + Cond Lidded #7094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheeezburga
added
the
enhancement
|
I think this should be an effect/condition rather than an expression that can only be true or false |
|
I'm in agreement with cheeze as paper has a new pr about a week ago aiming to add new lidded states not yet merged |
cheeezburga
suggested changes
Sep 19, 2024
agreed |
TheLimeGlass
requested changes
Sep 20, 2024
Efnilite
suggested changes
Sep 20, 2024
cheeezburga
suggested changes
Sep 20, 2024
Kept the changes that suited best between the overlapping requested changes
cheeezburga
suggested changes
Sep 20, 2024
cheeezburga
approved these changes
Sep 22, 2024
Efnilite
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add setting the open/close animation of lidded blocks (chests, enderchests, barrels, and shulker boxes)
Target Minecraft Versions: any
Requirements: none
Related Issues: #5715