Add a way to get patterns from the PropertyCondition #7107
Conversation
| /** | ||
| * Indicates that the condition is in a form of <code>something is/are something</code>, | ||
| * also possibly in the negated form | ||
| */ | ||
| IS, | ||
|
|
There was a problem hiding this comment.
this is just BE, why does it need to be added
There was a problem hiding this comment.
BE doesn't equal is/are. There is no reference to BE anywhere. Nico realized this after the PR.
There was a problem hiding this comment.
well is/are are conjugated forms of "to be", so BE makes sense
There was a problem hiding this comment.
Is this blocking to not have both enums?
There was a problem hiding this comment.
Yeah, either rename BE or keep BE (i prefer keeping)
It's just confusing to have two types that do and mean the exact same thing
There was a problem hiding this comment.
renaming would be a breaking change!
There was a problem hiding this comment.
Not renaming, it's adding the proper terminology.
sovdeeth
added
the
enhancement
| * @param type must be plural, for example <i>players</i> in <i>players can fly</i> | ||
| * @return patterns formmated for {@link Skript#registerCondition(Class, String...)} | ||
| */ | ||
| public static String[] getPatterns(PropertyType propertyType, String property, String type) { |
There was a problem hiding this comment.
i'd prefer this be private. if someone wants to get the patterns they could use the syntaxelementinfo
There was a problem hiding this comment.
I'd like it to be public so other syntaxes can use the property patterns without being property conditions, and without duplicating code.
Description
Adds a way to get the property condition patterns, since I see many people making patterns similar to PropertyCondition but can't use the PropertyCondition register method due to the pattern.
This allows developers to collect and use the patterns in the way they want.
Target Minecraft Versions: any
Requirements: none
Related Issues: none