Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update files to match checkstyle (part 1) #7117

Open
wants to merge 13 commits into
base: dev/patch
Choose a base branch
from

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Sep 27, 2024

Description

Updates some of the worst offenders, who are least likely to be affected by other PRs.

  • Removed the copyright header, used IntellIJ's formatting shortcut, and split lines that were >120 chars.
  • Moved the Parsers and Serializers in JavaClasses to separate inner classes with IntellIJ's "To named inner class" shortcut.
  • Renamed variables and removed finals

Removes around 700 violations, or 10% of total.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite marked this pull request as ready for review September 27, 2024 09:43
@Efnilite Efnilite added the housekeeping Housekeeping-related issue or task. label Sep 27, 2024
Copy link
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some es that could be events, and switches that could be updated, but if this is just a styling thing then looks good

src/main/java/ch/njol/skript/effects/EffFeed.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/entity/RabbitData.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Housekeeping-related issue or task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants