-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shouldn't check length of Material #7121
Conversation
I strongly recommend to approve this PR because:
i know that Skript doesn't support Hybird servers, but this PR is intended to improve the scalability of Skript, not just for Hybird servers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me
Wdym? |
sorry I made a mistake.. |
@0XPYEX0 it looks like the PR doesn't work as your expect, please check it again |
If any other changes need to be made, feel free to open another PR |
Description
We shouldn't check ID length while getting a material.
Bukkit checked it:
If we check it, Skript cannot parse aliases of mod items (In Hybrid Server)
Target Minecraft Versions: any
Requirements: none
Related Issues: none