Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't check length of Material #7121

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

0XPYEX0
Copy link
Contributor

@0XPYEX0 0XPYEX0 commented Oct 1, 2024

Description

We shouldn't check ID length while getting a material.
Bukkit checked it:
bc5e232100eac8b56d9931d8d80a829e

If we check it, Skript cannot parse aliases of mod items (In Hybrid Server)

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@BredyAK
Copy link

BredyAK commented Oct 1, 2024

I strongly recommend to approve this PR because:

  1. in future minecraft versions, maybe there will be a way to directly add blocks/items to minecraft by datapack. then the namespace may not be minecraft. but currently Skript doesn't support to create aliases for items which do not use minecraft as their namespace.
  2. as the 1st opinion said, if this PR is approved, then Hybird servers will also benefit from this, which could let modded items being added to Skript aliases.
  3. this PR doesn't break any Skript's current core things, but increased scalability.
  4. there are a lot of people want this too, such as https://forums.skunity.com/threads/14952/, https://forums.skunity.com/threads/9848/, https://forums.skunity.com/threads/14457/, etc. if you google "Skript Mod Item" or something similiar, you could find a lot more.

i know that Skript doesn't support Hybird servers, but this PR is intended to improve the scalability of Skript, not just for Hybird servers.

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@Efnilite Efnilite added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Oct 1, 2024
@Efnilite
Copy link
Member

Efnilite commented Oct 1, 2024

@Efnilite May I ask your permission again? I merged the branch and it seems invalid🥺

Wdym?

@0XPYEX0
Copy link
Contributor Author

0XPYEX0 commented Oct 1, 2024

@Efnilite May I ask your permission again? I merged the branch and it seems invalid🥺

Wdym?

sorry I made a mistake..

@BredyAK
Copy link

BredyAK commented Oct 1, 2024

@Efnilite May I ask your permission again? I merged the branch and it seems invalid🥺

Wdym?

@Efnilite maybe he means to ask you to review the PR again, because he updated his codes after your last review.

@sovdeeth sovdeeth added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Oct 1, 2024
@BredyAK
Copy link

BredyAK commented Oct 1, 2024

If we check it, Skript cannot parse aliases of mod items (In Hybrid Server)

@0XPYEX0 it looks like the PR doesn't work as your expect, please check it again

@APickledWalrus APickledWalrus merged commit cd65207 into SkriptLang:dev/patch Oct 1, 2024
7 checks passed
@APickledWalrus
Copy link
Member

If any other changes need to be made, feel free to open another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants