Fixes 5804-is-burning regression test #7124
Open
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously used a wait to allow the pig's fire ticks to update, but waits aren't allowed in tests, so now just uses the ignite effect
Efnilite
added
the
bug
Efnilite
suggested changes
Oct 2, 2024
| @@ -1,9 +1,14 @@ | |||
| # This test is to see if the `is burning` condition works properly. | |||
There was a problem hiding this comment.
not sure this explanation is needed, they can just pull up the issue from the github right?
There was a problem hiding this comment.
They can, just saves a bit of time was my thinking behind it
Co-authored-by: Efy <[email protected]>
sovdeeth
approved these changes
Oct 2, 2024
APickledWalrus
approved these changes
Oct 2, 2024
Efnilite
approved these changes
Oct 2, 2024
Efnilite
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Skript tests failing, due to a wait being used to allow the pig's fire ticks to update. Waits aren't allowed in tests, so now just uses the ignite effect.
Target Minecraft Versions: any
Requirements: none
Related Issues: none