This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Handle SameSite=None is unsupported by some old browsers
#1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmenlau
force-pushed
the
1368-handle-same-site-none
branch
2 times, most recently
from
49154c5
to
949d0db
Compare
pkg/core/samesite/utils.go
Outdated
| @@ -0,0 +1,115 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
It's better to name this file and its test file samesite/incompatible.go
kiootic
reviewed
May 12, 2020
| // some old browsers | ||
| // To avoid writing samesite to the header | ||
| // set empty value to Cookie SameSite | ||
| // https://golang.org/src/net/http/cookie.go#L220 |
There was a problem hiding this comment.
I just searched and found this issue: golang/go#36990
We may want to include the issue link for completeness.
carmenlau
force-pushed
the
1368-handle-same-site-none
branch
from
949d0db
to
4d30faf
Compare
|
Updated @louischan-oursky @kiootic |
kiootic
approved these changes
May 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #1368
Tested login in Mac Chrome 60