Upgrade dependencies #449
Merged
Upgrade dependencies #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
shaundon
previously approved these changes
Jan 16, 2018
|
I'm not done :) |
|
You should add the WIP label then 😉 |
|
Good shout :) |
| @@ -8,7 +8,7 @@ exports[`Android BpkCard should render correctly 1`] = ` | |||
| accessibilityComponentType="button" | |||
| accessibilityLabel="Example Card" | |||
| background={undefined} | |||
| onPress={[Function]} | |||
| onPress={[MockFunction]} | |||
There was a problem hiding this comment.
Just checking, is this change because of the Jest update to 22?
There was a problem hiding this comment.
Yeah they've changed the serialization of jest.fn to be clearer. See jestjs/jest#4668
matthewdavidson
previously approved these changes
Jan 16, 2018
package.json
Outdated
| "ios": "(cd ./native && npm run ios)", | ||
| "android": "(cd ./native && npm run android)", | ||
| "check-owners": "npm whoami && ( node scripts/npm/get-owners.js | grep -E $(npm whoami) ) && node scripts/npm/check-owners.js", | ||
| "publish": "npm run check-owners && npm run build && git pull --rebase && npm run flow stop && npm run test && lerna publish", | ||
| "danger": "danger", | ||
| "danger:ci": "danger ci", |
There was a problem hiding this comment.
Since there is only one task for "danger", keep it as "danger"
added 5 commits
January 16, 2018 13:47
Stylelint is pinned at 8.2.0 as the upgrade to 8.4.0 broke it for us. See stylelint/stylelint#3130.
k0nserv
force-pushed
the
upgrade-dependencies
branch
from
8344c74
to
54bec36
Compare
k0nserv
force-pushed
the
upgrade-dependencies
branch
from
54bec36
to
eb9494a
Compare
added 2 commits
January 16, 2018 14:36
This reverts commit 0cf1592.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.