Update GenericResourceWildcardPolicyRule to use REGEX_CONTAINS_WILDCARD #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocrawford555
approved these changes
May 30, 2022
ignaciobolonio
approved these changes
May 30, 2022
w0rmr1d3r
deleted the
update_GenericResourceWildcardPolicyRule_with_wildcard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing some internal research of data, the Generic rule
GenericResourceWildcardPolicyRuleflagged more resources that the intended when it was first created. We found out as well that it was overlapping with other rules such asIAMRoleWildcardActionOnPolicyRuledue to the regexes being used.[1.11.0]
Additions
REGEX_CONTAINS_WILDCARDto check for any wildcardUpdates
GenericResourceWildcardPolicyRulenow usesREGEX_CONTAINS_WILDCARDinstead ofREGEX_HAS_STAR_OR_STAR_AFTER_COLON.mototo==3.1.9.