Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a direct include file for using the classifier #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jpswinski
Copy link
Member

@jpswinski jpswinski commented Oct 2, 2024

Purpose

To directly include the OpenOceans++ classifier header from the sliderule code

Changes

  • Some #include directives were modified so that relative paths were consistently used. Reason: with in the sliderule build the same compilation unit will include both this classifier and other classifiers that have the exact same header filenames; this makes it difficult to set global include paths - evne if they are separated out when included from sliderule code, the locally included files are no longer able to be found

  • Fixed all occurrences of an aliased variable. Reason: sliderule builds enforce strict policies on compiler warnings (sometimes annoyingly so, but we've committed to it and it pays off).

@jpswinski jpswinski requested a review from jeffsp October 2, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant