FIx dough-common and co being on the wrong scope in dough modules #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it the wrong scope though? |
|
Walshy mentioned that it was on the wrong scope. I'm not sure why so I guess I'll have to ping here and ask for the explanation. @WalshyDev |
|
Yeah, right now you can't just use a singular module. It should include all the needed dependencies but in this case, it doesn't. Meaning I need to specify common myself There should be no issues in any modules if the deps are just done correctly. For example, the item module shouldn't include common in since it'll be inherited already through reflections This is common practice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.