Add nested filter on customer group id for price filter. #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@romainruaud It is working perfectly for me! 👍 I did a few tests by switching between different customer group on different websites and checking the raw ES request at the same time. The company I am working for is using most of Magento advanced pricing features on a single instance so it is a good way for me to see if something is working as expected or not (in the absence of integration tests). Thanks a lot for the update! Now the only issue I have left is this one that I fixed in a PR: #1003 I am waiting for your feedback. 😉 |
romainruaud
force-pushed
the
fix_price-filter-customer-group
branch
from
2b04d4a
to
8cf67ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1096
@nicobatty can you test this one and give me your feedback ?