Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure option text attributes values are using their "parent" field p… #116

Merged

Conversation

romainruaud
Copy link
Collaborator

…arameters for search usage : spellcheck, autocomplete, searchable, etc...

This is a fix for #94 and should be merge in master and 2.2.x

…arameters for search usage : spellcheck, autocomplete, searchable, etc...
@romainruaud
Copy link
Collaborator Author

I updated the PR. You were right, I broke some parts :)

See before/after on mapping :

BEFORE :

        "manufacturer" : {
            "type" : "integer",
            "fielddata" : {
              "format" : "doc_values"
            }
          }
        "option_text_manufacturer" : {
            "type" : "string",
            "analyzer" : "standard",
            "fielddata" : {
              "format" : "lazy"
            },
            "fields" : {
              "shingle" : {
                "type" : "string",
                "analyzer" : "shingle",
                "fielddata" : {
                  "format" : "lazy"
                }
              },
              "untouched" : {
                "type" : "string",
                "index" : "not_analyzed",
                "fielddata" : {
                  "format" : "doc_values"
                }
              },
              "whitespace" : {
                "type" : "string",
                "analyzer" : "whitespace",
                "fielddata" : {
                  "format" : "lazy"
                }
              }
            },
            "copy_to" : [ "search" ]
          }

and AFTER :

        "manufacturer" : {
            "type" : "integer",
            "fielddata" : {
              "format" : "doc_values"
            }
          },
       "option_text_manufacturer" : {
            "type" : "string",
            "analyzer" : "standard",
            "fielddata" : {
              "format" : "lazy"
            },
            "fields" : {
              "phonetic" : {
                "type" : "string",
                "analyzer" : "phonetic",
                "fielddata" : {
                  "format" : "lazy"
                }
              },
              "shingle" : {
                "type" : "string",
                "analyzer" : "shingle",
                "fielddata" : {
                  "format" : "lazy"
                }
              },
              "untouched" : {
                "type" : "string",
                "index" : "not_analyzed",
                "fielddata" : {
                  "format" : "doc_values"
                }
              },
              "whitespace" : {
                "type" : "string",
                "analyzer" : "whitespace",
                "fielddata" : {
                  "format" : "lazy"
                }
              }
            },
            "copy_to" : [ "search", "spelling" ]
          }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants