Replace io-lifetimes with std::os::fd #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkmauve
force-pushed
the
stub-out-io-lifetimes
branch
from
78ac2a8
to
50a1ec4
Compare
Since Rust 1.63, most of the features of io-lifetimes have been merged into std, including the only three we are using: OwnedFd, BorrowedFd and the AsFd trait. This bumps our MSRV, but this is the MSRV of the newest io-lifetimes anyway. I kept reexporting io_lifetimes as it was part of the public interface, but since it isn’t used any more it would be nice to remove it before the next minor version bump. I can prepare a commit for that.
linkmauve
force-pushed
the
stub-out-io-lifetimes
branch
from
50a1ec4
to
3855776
Compare
elinorbgr
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Rust 1.63, most of the features of io-lifetimes have been merged into std, including the only three we are using:
OwnedFd,BorrowedFdand theAsFdtrait.This bumps our MSRV, but this is the MSRV of the newest io-lifetimes anyway.
I kept reexporting
io_lifetimesas it was part of the public interface, but since it isn’t used any more it would be nice to remove it before the next minor version bump. I can prepare a commit for that.This partially conflicts with #640.