Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: Use Message<_, BorrowedFd> rather than RawFd #678

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Nov 20, 2023

This is a breaking change to wayland-backend, but not to wayland-client or wayland-server. I believe that should be fine.

This avoids an unsafe conversion in the rs backend.

Based on #677.

@elinorbgr
Copy link
Member

Make a breaking change in wayland-backend will force a following breaking release in wayland-client and wayland-server anyway, but I think this is a direction we want to go.

@ids1024
Copy link
Member Author

ids1024 commented Nov 21, 2023

Oh right, those crates expose the Backend type, so it's a public dependency. Otherwise such a change would be non-breaking.

This change can be left until the next time wayland-rs has a breaking change. This isn't urgent since it isn't actually a soundness issue and shouldn't impact behavior. (And indeed, the fact this change works confirms that the RawFds are already being used correctly.)

This is a breaking change to `wayland-backend`, but not to
`wayland-client` or `wayland-server`. I believe that should be fine.

This avoids an unsafe conversion in the `rs` backend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants