wayland-server: alive check for Weak #720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
smithay
we quite extensively useWeak
as the key for caching some other resource. Cleaning up these resourcesoften requires checking if the key is still alive. Without an explicit function to check
Weak
for alive we have to resort toWeak::upgrade().is_ok()
. An explicit function can save us from actually upgrading the resource itself, saving us quite some cpu time.