Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wl_fixes protocol #726

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

wl_fixes protocol #726

wants to merge 2 commits into from

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented May 11, 2024

In addition to copying the protocol changes from https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/388, this required two things:

  • Modifies wayland-scanner to generate a WlRegistry type server-side. Instead of trying to make it produce a valid parse_request to handle the special case of the bind request, it just uses unimplemented!.
  • Adds a destroy_object method to destroy the object
    • Not sure if this is entirely correct as implemented.

See Smithay/smithay#1428 for server-side use of this.

@ids1024 ids1024 force-pushed the wl-fixes branch 6 times, most recently from 3168907 to 466e18c Compare May 15, 2024 21:37
This is needed for implementing the `wl_fixes` protocol. It should also
make it possible to handle the requirement in
`zwlr_output_configuration_v1::destroy` to destroy the
`wlr_output_configuration_head`.
@ids1024
Copy link
Member Author

ids1024 commented May 16, 2024

I guess the server should also remove the registry from known_registries (looks like currently elements are only removed their when the client is gone.) Not sure if there's anything else that might need to be removed anywhere on registry destruction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant