Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table_format not supported with snowflake_external_table resource #1564

Open
raaghul-umapathy opened this issue Feb 22, 2023 · 6 comments
Open
Labels
category:resource feature-request Used to mark issues with provider's missing functionalities resource:external_table Issue connected to the snowflake_external_table resource

Comments

@raaghul-umapathy
Copy link

Provider Version

0.55.1

Terraform Version

1.3.9

Describe the bug

when using the external table resource - snowflake_external_table to create the external table on s3 delta table, it is not accepting the table_format as a valid resource property.

Expected behavior

Since the s3 table is a delta table and it is valid variable in snowflake external table object, it is expected to accept the table_format as a valid variable for the external table terraform resource.

Code samples and commands

Actual resource code:

resource "snowflake_external_table" "external_table" {
  name     = upper("pipe1_view")
  database = upper(var.sf_database)
  schema   = upper(var.sf_schema)

  comment     = "some commets"
  partition_by = ["landing_date"]
  file_format = "TYPE = parquet"

  location="@public._S3_SVD_stage/"
  refresh_on_create =  false
  auto_refresh = false
  table_format = "delta"
;

cmd - Terraform plan

The output that produces after Terraform plan.

│ Error: Unsupported argument
│ 
│   on modules/snowflake/main.tf line 40, in resource "snowflake_external_table" "external_table":
│   40:   table_format = "delta"
│ 
│ An argument named "table_format" is not expected here.
@raaghul-umapathy raaghul-umapathy added the bug Used to mark issues with provider's incorrect behavior label Feb 22, 2023
@ksarang90
Copy link

Any update on this issue? We are also planning to use delta lake format on Snowflake external tables. It will be super helpful feature!

@developmentalmadness
Copy link

+1 for adding this support.

@sfc-gh-asawicki sfc-gh-asawicki added feature-request Used to mark issues with provider's missing functionalities and removed bug Used to mark issues with provider's incorrect behavior labels Nov 14, 2023
@sfc-gh-asawicki
Copy link
Collaborator

Hey @raaghul-umapathy. Thanks for creating the issue.

We are currently changing the implementation used in resources as a part of our ongoing SDK rewrite. @sfc-gh-jcieslak is currently working on the external table resource, so he will add this missing parameter as a part of the process.

@sfc-gh-jcieslak
Copy link
Collaborator

Hey @justin-ramirez-gametime
Could you confirm you can use table_format with the latest provider version?

@justin-ramirez-gametime

We do not currently use table_format for our external tables

@sfc-gh-jcieslak
Copy link
Collaborator

Sorry didn't mean to @ you 😅
@raaghul-umapathy ⬆️

@sfc-gh-jcieslak sfc-gh-jcieslak added category:resource resource:external_table Issue connected to the snowflake_external_table resource labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:resource feature-request Used to mark issues with provider's missing functionalities resource:external_table Issue connected to the snowflake_external_table resource
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants