fix: external tables issues #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jcieslak
force-pushed
the
fix-external-tables-issues
branch
from
35f2551
to
79da064
Compare
|
Integration tests failure for 35f25515f960ee90efc9d64bf6db96e7b5234964 |
|
Integration tests failure for 79da064e10e3aba6d3ff2717b2d2aed88f586632 |
sfc-gh-asawicki
approved these changes
Jan 10, 2024
sfc-gh-jcieslak
changed the title
|
Integration tests failure for 79da064e10e3aba6d3ff2717b2d2aed88f586632 |
sfc-gh-jcieslak
force-pushed
the
fix-external-tables-issues
branch
from
79da064
to
b05f32d
Compare
|
Integration tests failure for b05f32d8dc41994c3d4282dee9a01d155e0fe1a3 |
sfc-gh-swinkler
approved these changes
Jan 11, 2024
sfc-gh-jcieslak
force-pushed
the
fix-external-tables-issues
branch
from
b05f32d
to
5f227ab
Compare
|
Integration tests failure for 5f227ab30fa75f982d19dfb3d28a588c809059fb |
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Jan 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.83.0](v0.82.0...v0.83.0) (2024-01-11) ### 🎉 **What's new:** * Add create streamlit privilege to the SDK ([#2303](#2303)) ([be01d5f](be01d5f)) * grant privileges to database role resource ([#2306](#2306)) ([0311cf8](0311cf8)) ### 🐛 **Bug fixes:** * Add secondary account and fix tests ([#2324](#2324)) ([da6ca73](da6ca73)) * external tables issues ([#2334](#2334)) ([ae41691](ae41691)) * Fix test because of the date ([#2312](#2312)) ([9a9ea33](9a9ea33)) * Fix warehouse read and resource monitor empty set ([#2319](#2319)) ([05f96c6](05f96c6)), closes [#2318](#2318) [#2316](#2316) * goreleaser for mfa token caching ([#2320](#2320)) ([4fef709](4fef709)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Fix for
#2310 - (bugfix) - column_type was mapping incorrectly column data types. It was using
sdk.ToDataTypewhich strips down some of the information. Had to replacesdk.ToDataTypewith plain mappingsdk.DataType(column_type).#2293 - (bugfix) -
partition bywas incorrectly mapped from the request to SQL struct. Had to add the field in mapping.#1564 - (feature request) - introduce
table_format = "delta"field to the schema. Had to differentiate the external table type in the Create operation to choose the correct create option from the ExternalTables interface.Test Plan
References