Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: grant privileges to database role resource #2306

Merged
merged 16 commits into from
Jan 11, 2024
Merged

feat: grant privileges to database role resource #2306

merged 16 commits into from
Jan 11, 2024

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Dec 22, 2023 •
edited
Loading

Add new snowflake_grant_privileges_to_database_role resource.

TODO:

  • Handle IMPORTED PRIVILEGES privilege after a second account is created
  • Links to the documentation

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the snowflake-grant-privileges-to-database-role-resource branch from ea01954 to 5dc79aa Compare December 22, 2023 15:16
@github-actions GitHub Actions
Copy link

Integration tests failure for ea0195400fbb65487bc01647ceef34f7c5fba360

@github-actions GitHub Actions
Copy link

Integration tests failure for 5dc79aa845bdf766bd68335b11cf22fa8ccd5e47

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Integration tests failure for 631db5a0051627e8377d7552f5d70920fcb1ccf0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Integration tests failure for 6767e9d066b25d56e55dc46c8523ef6fd966eaad

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Integration tests failure for 778b734a1d5527f0e077a9c0506e3efda5cb2197

@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review January 3, 2024 14:14
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the snowflake-grant-privileges-to-database-role-resource branch from 6641d4f to 8e15592 Compare January 3, 2024 14:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Integration tests failure for 6641d4f8d38902d4303920f95c0f501557cb05a2

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Integration tests failure for 8e155921a1ef5e0526c3e6e83566249364e1b0ea

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

Integration tests failure for 9d0ab46419ddda2018a9da44e294b24732402906

sfc-gh-asawicki
sfc-gh-asawicki requested changes Jan 4, 2024
View reviewed changes
pkg/resources/grant_privileges_to_database_role.go Outdated Show resolved Hide resolved
pkg/resources/grant_privileges_to_database_role.go Outdated Show resolved Hide resolved
pkg/resources/grant_privileges_to_database_role_acceptance_test.go Show resolved Hide resolved
pkg/resources/grant_privileges_to_database_role_acceptance_test.go Show resolved Hide resolved
pkg/resources/grant_privileges_to_database_role.go Show resolved Hide resolved
pkg/resources/grant_privileges_to_database_role_acceptance_test.go Show resolved Hide resolved
pkg/resources/grant_privileges_to_database_role_identifier_test.go Show resolved Hide resolved
pkg/resources/grant_privileges_to_database_role.go Outdated Show resolved Hide resolved
pkg/resources/testdata/TestAcc_GrantPrivilegesToDatabaseRole_AlwaysApply/test.tf Outdated Show resolved Hide resolved
pkg/resources/grant_privileges_to_database_role.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

Integration tests failure for ee9de174531145edc55bb43226f3af3c96628906

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the snowflake-grant-privileges-to-database-role-resource branch from ee9de17 to f935612 Compare January 8, 2024 09:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

Integration tests failure for f935612de69e2ef300d2c104a1b6b423e2fd94c0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

Integration tests failure for c1633d9b596d9891e0161b4fb12486d836e6aa9a

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the snowflake-grant-privileges-to-database-role-resource branch from c1633d9 to b3f933a Compare January 8, 2024 10:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

Integration tests failure for b3f933a1a248afdd63d68956f4a26d421ca81d38

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the snowflake-grant-privileges-to-database-role-resource branch from 1f8ebb6 to eacccb0 Compare January 9, 2024 10:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Integration tests failure for eacccb0f09af6eb2b2d608d064e82c8eadc49354

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Integration tests failure for 1f8ebb65bc553b29a68da64d141fd588435a0cdf

sfc-gh-asawicki
sfc-gh-asawicki previously approved these changes Jan 9, 2024
View reviewed changes
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the snowflake-grant-privileges-to-database-role-resource branch from 1a551af to b3ae822 Compare January 9, 2024 10:52
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the snowflake-grant-privileges-to-database-role-resource branch from b3ae822 to 7657134 Compare January 9, 2024 10:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Integration tests failure for 1a551aff5b610109a554913572735103329903fb

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Integration tests failure for b3ae8223f2b26384858300dd5a23cc1049f81ec0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Integration tests failure for 7657134a02cd000866ea877e5bc7d38168fae612

sfc-gh-swinkler
sfc-gh-swinkler reviewed Jan 9, 2024
View reviewed changes
docs/resources/grant_privileges_to_database_role.md Show resolved Hide resolved
pkg/resources/grant_privileges_to_database_role.go
Description: "If true, the resource will always produce a “plan” and on “apply” it will re-grant defined privileges. It is supposed to be used only in “grant privileges on all X’s in database / schema Y” or “grant all privileges to X” scenarios to make sure that every new object in a given database / schema is granted by the account role and every new privilege is granted to the database role. Important note: this flag is not compliant with the Terraform assumptions of the config being eventually convergent (producing an empty plan).",
},
"always_apply_trigger": {
Type: schema.TypeString,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it make more sense for this to be a boolean flag instead of a string? also I think it would be circumsantially usefully to set manually. for example, you could check the current time and only apply once per day, or once per week.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first, it was a boolean, but I thought it could be acting wrongly in some scenarios. For example, the only place where this flag could be switched is in the Read operation (because it is invoked on every tf action), but then we could end up in a situation where sometimes it triggers and sometimes doesn't (mostly because Update operation calls Read at the end). With random strings, we don't have to think about it and wonder if it will be switched correctly because it will be always a different value.

pkg/resources/grant_privileges_to_database_role.go Outdated Show resolved Hide resolved
pkg/resources/testdata/TestAcc_GrantPrivilegesToDatabaseRole_OnAllSchemasInDatabase/test.tf Outdated Show resolved Hide resolved
templates/resources/grant_privileges_to_database_role.md.tmpl Show resolved Hide resolved
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the snowflake-grant-privileges-to-database-role-resource branch from 8a13e19 to cc39e2c Compare January 10, 2024 10:22
@github-actions GitHub Actions
Copy link

Integration tests failure for 8a13e1951fb3afae98beb56be4d519f367906587

@github-actions GitHub Actions
Copy link

Integration tests failure for cc39e2c096990fb6a2b8fe0ed4e4971ef13d7d28

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 0311cf8 into main Jan 11, 2024
7 of 8 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the snowflake-grant-privileges-to-database-role-resource branch January 11, 2024 13:48
@snowflake-release-please snowflake-release-please bot mentioned this pull request Jan 11, 2024
Merged
sfc-gh-jcieslak pushed a commit that referenced this pull request Jan 11, 2024
@snowflake-release-please
chore(main): release 0.83.0 (#2305)
ac5dd36 
🤖 I have created a release *beep* *boop*
---


##
[0.83.0](v0.82.0...v0.83.0)
(2024-01-11)


### 🎉 **What's new:**

* Add create streamlit privilege to the SDK
([#2303](#2303))
([be01d5f](be01d5f))
* grant privileges to database role resource
([#2306](#2306))
([0311cf8](0311cf8))


### 🐛 **Bug fixes:**

* Add secondary account and fix tests
([#2324](#2324))
([da6ca73](da6ca73))
* external tables issues
([#2334](#2334))
([ae41691](ae41691))
* Fix test because of the date
([#2312](#2312))
([9a9ea33](9a9ea33))
* Fix warehouse read and resource monitor empty set
([#2319](#2319))
([05f96c6](05f96c6)),
closes
[#2318](#2318)
[#2316](#2316)
* goreleaser for mfa token caching
([#2320](#2320))
([4fef709](4fef709))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
@sfc-gh-asawicki sfc-gh-asawicki mentioned this pull request Jan 19, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-swinkler sfc-gh-swinkler sfc-gh-swinkler left review comments

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jcieslak @sfc-gh-swinkler @sfc-gh-asawicki