fix: goreleaser for mfa token caching #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-swinkler
changed the title
|
Integration tests failure for 852ecb09f31c0067cafb2901cfd77b02de51955f |
sfc-gh-asawicki
approved these changes
Jan 8, 2024
sfc-gh-jcieslak
approved these changes
Jan 8, 2024
|
@sfc-gh-swinkler One comment: can you link the GH issue that this PR fixes? |
|
Integration tests failure for f023c0ca06b31dbe575969c8ec582080d5df0746 |
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Jan 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.83.0](v0.82.0...v0.83.0) (2024-01-11) ### 🎉 **What's new:** * Add create streamlit privilege to the SDK ([#2303](#2303)) ([be01d5f](be01d5f)) * grant privileges to database role resource ([#2306](#2306)) ([0311cf8](0311cf8)) ### 🐛 **Bug fixes:** * Add secondary account and fix tests ([#2324](#2324)) ([da6ca73](da6ca73)) * external tables issues ([#2334](#2334)) ([ae41691](ae41691)) * Fix test because of the date ([#2312](#2312)) ([9a9ea33](9a9ea33)) * Fix warehouse read and resource monitor empty set ([#2319](#2319)) ([05f96c6](05f96c6)), closes [#2318](#2318) [#2316](#2316) * goreleaser for mfa token caching ([#2320](#2320)) ([4fef709](4fef709)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
sfc-gh-jcieslak
added a commit
that referenced
this pull request
Jan 12, 2024
This reverts commit 4fef709.
|
@sfc-gh-jcieslak is this merge really tested? Because for me the MFA Caching is not working and I get a prompt on every terraform action I do |
|
Hey @sfc-gh-asawicki, thanks for the fast reply. Sure. I just searched a little in the last messages and found both places which made me a little insecure where is the right place to put it. Let´s contine with my other comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mfa token caching does not work for windows / darwin OS when CGO is disabled. Its recommended to turn of CGO for performance reasons, so adding an env variable to gorelaser to only turn on CGO for windows and darwin
fixes:
#908
#2194