Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user password policy attachment #2627

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

Our test for the user password policy attachment resource started failing. It detected two issues with current implementation that were changed:

  • POLICY_STATUS should be a nullable field (this is something new because the test started failing just recently)
  • policyReferences returned by GetForEntity should be filtered by PASSWORD_POLICY PolicyKind to resolve clashes with other policy types

Copy link

Integration tests success for c1cd4a12f8dc13dc0a817d2295c408d0234e990d

@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review March 21, 2024 09:47
@sfc-gh-jcieslak sfc-gh-jcieslak changed the title fix: user password policy attachment feat: user password policy attachment Mar 21, 2024
@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 382e49d into main Mar 21, 2024
10 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the fix-password-policy-attachment branch March 21, 2024 09:48
sfc-gh-swinkler pushed a commit that referenced this pull request Mar 25, 2024
Our test for the user password policy attachment resource started
failing. It detected two issues with current implementation that were
changed:
- POLICY_STATUS should be a nullable field (this is something new
because the test started failing just recently)
- policyReferences returned by GetForEntity should be filtered by
`PASSWORD_POLICY` PolicyKind to resolve clashes with other policy types
sfc-gh-jcieslak pushed a commit that referenced this pull request Apr 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.88.0](v0.87.3-pre...v0.88.0)
(2024-04-09)


### 🎉 **What's new:**

* Fix issues 2651 2656
([#2659](#2659))
([7fa09cc](7fa09cc))
* Grant ownership follow up
([#2628](#2628))
([d467e5b](d467e5b))
* grant ownership follow-up
([#2658](#2658))
([bfa2317](bfa2317))
* grant ownership on tasks
([#2684](#2684))
([2ba7889](2ba7889))
* Introduce shared function to suspend task roots
([#2650](#2650))
([d684b5d](d684b5d))
* Redesign snowflake_grants datasource
([#2667](#2667))
([918873d](918873d))
* user password policy attachment
([#2627](#2627))
([382e49d](382e49d))


### 🔧 **Misc**

* release 0.88.0
([02d60e0](02d60e0))
* Update grant examples in all resources
([#2660](#2660))
([b542b69](b542b69))


### 🐛 **Bug fixes:**

* Adjust dynamic tables after BCR-1543
([#2664](#2664))
([cf32ceb](cf32ceb))
* Fix handling secure views read and import
([#2655](#2655))
([3c3ede6](3c3ede6))
* Fix issues 2606 2642 2652 2653
([#2654](#2654))
([4a73721](4a73721))
* Fix release workflow
([#2639](#2639))
([dfd07e9](dfd07e9))
* Generate docs for dynamic table
([#2666](#2666))
([16c75b0](16c75b0))
* grant read operation
([#2665](#2665))
([0b947a5](0b947a5))
* migration guide for databases created from share
([#2637](#2637))
([f9651bc](f9651bc))
* with_grant_option diff drift
([#2608](#2608))
([f0018c6](f0018c6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants