chore: Update grant examples in all resources #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for 0987b75fd94865145801e78d93db72e25d8007e3 |
| @@ -6,11 +6,3 @@ resource "snowflake_stage" "example_stage" { | |||
| schema = "EXAMPLE_SCHEMA" | |||
| credentials = "AWS_KEY_ID='${var.example_aws_key_id}' AWS_SECRET_KEY='${var.example_aws_secret_key}'" | |||
| } | |||
|
|
|||
| resource "snowflake_stage_grant" "grant_example_stage" { | |||
There was a problem hiding this comment.
Should we remove this ownership grant or add todo for SNOW-991423 (grant ownership implementation)?
There was a problem hiding this comment.
No other resource have such an example, so my choice was to remove and not do a follo-up just for this one
| ResourceName: "snowflake_file_format.test", | ||
| ImportState: true, | ||
| ImportStateVerify: true, | ||
| ImportStateVerifyIgnore: []string{}, |
There was a problem hiding this comment.
ImportStateVerifyIgnore can be fully removed
There was a problem hiding this comment.
Oky, will remove in some other change, oky?
|
Integration tests failure for 0987b75fd94865145801e78d93db72e25d8007e3 |
|
Integration tests success for feda9b69bb3eafc3c551a1502c9a83075ca3849d |
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Apr 9, 2024
🤖 I have created a release *beep* *boop* --- ## [0.88.0](v0.87.3-pre...v0.88.0) (2024-04-09) ### 🎉 **What's new:** * Fix issues 2651 2656 ([#2659](#2659)) ([7fa09cc](7fa09cc)) * Grant ownership follow up ([#2628](#2628)) ([d467e5b](d467e5b)) * grant ownership follow-up ([#2658](#2658)) ([bfa2317](bfa2317)) * grant ownership on tasks ([#2684](#2684)) ([2ba7889](2ba7889)) * Introduce shared function to suspend task roots ([#2650](#2650)) ([d684b5d](d684b5d)) * Redesign snowflake_grants datasource ([#2667](#2667)) ([918873d](918873d)) * user password policy attachment ([#2627](#2627)) ([382e49d](382e49d)) ### 🔧 **Misc** * release 0.88.0 ([02d60e0](02d60e0)) * Update grant examples in all resources ([#2660](#2660)) ([b542b69](b542b69)) ### 🐛 **Bug fixes:** * Adjust dynamic tables after BCR-1543 ([#2664](#2664)) ([cf32ceb](cf32ceb)) * Fix handling secure views read and import ([#2655](#2655)) ([3c3ede6](3c3ede6)) * Fix issues 2606 2642 2652 2653 ([#2654](#2654)) ([4a73721](4a73721)) * Fix release workflow ([#2639](#2639)) ([dfd07e9](dfd07e9)) * Generate docs for dynamic table ([#2666](#2666)) ([16c75b0](16c75b0)) * grant read operation ([#2665](#2665)) ([0b947a5](0b947a5)) * migration guide for databases created from share ([#2637](#2637)) ([f9651bc](f9651bc)) * with_grant_option diff drift ([#2608](#2608)) ([f0018c6](f0018c6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_grantresources) from the non-deprecated resources/datasources (only one)._grantand_grantsresources from resource and datasource acceptance tests (only from the non-deprecated resources/datasources).