Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix sync_password field for Azure scim clients #2950

Merged
merged 8 commits into from
Jul 25, 2024
Merged

Conversation

sfc-gh-jmichalak
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak commented Jul 19, 2024

  • add a state upgrader to set default for affected resources
  • add an entry the in migration guide with explanation of the issue (also add a warning for v0.93)
  • add sdk validation for setting conflicting values
  • add resource validation for setting conflicting values in create/update (can't do it as ValidateFunc because it has scope of only one field)
  • add acceptance tests to cover flow with this issue
  • improve docs for other security integrations

Test Plan

  • acceptance tests
  • unit tests

References

References #2946, #2927.

@sfc-gh-jmichalak sfc-gh-jmichalak changed the title fix: Fix sync password for azure scim clients fix: Fix sync_password field for Azure scim clients Jul 19, 2024
Copy link

Integration tests failure for 5c03c592220bff3e1edf4e89bd3899ac7e58cd74

Copy link

Integration tests failure for 771a9dab74fc39cfaae47fb49a2dccfcca16e2b9

Copy link

Integration tests failure for 32c55ad4d26924ba730af854540265fd2c768852

@sfc-gh-jmichalak sfc-gh-jmichalak marked this pull request as ready for review July 22, 2024 11:39
Copy link

Integration tests failure for 12669523b24bd4eabff8ceafc4b496d2068614a9

Copy link

Integration tests failure for 90b8c4b98d59e3ed152e763433cc789691af5373

Copy link

Integration tests failure for e4984c159113d43b9e1fcb1b98d034965b061d2e

Copy link

Integration tests failure for e5ecd2f0eff07a97c68e23fa39acda7d77fc816c

Copy link

Integration tests failure for 176d3b9caf5a5ac93606c81d31be14da4ea35d80

Copy link

Integration tests failure for e656eba6199bd87dc11138981f3fe3fe7e5baaae

Copy link

Integration tests failure for 76d8c3a303363f7626c3ab0b1bb8cb19f78caad1

Copy link

Integration tests failure for f6f80860f8eca421d4b6488b4fc9f6c697b4e0f5

@sfc-gh-jmichalak sfc-gh-jmichalak merged commit 6781133 into main Jul 25, 2024
10 of 11 checks passed
@sfc-gh-jmichalak sfc-gh-jmichalak deleted the fix-scim branch July 25, 2024 12:50
sfc-gh-jcieslak pushed a commit that referenced this pull request Jul 26, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.94.0](v0.93.0...v0.94.0)
(2024-07-26)


### 🎉 **What's new:**

* Add missing session parameters
([#2936](#2936))
([4ce662d](4ce662d))
* Adjust user SDK
([#2947](#2947))
([1127bb3](1127bb3))
* Better tests poc
([#2917](#2917))
([ef496c2](ef496c2))
* Introduce assertions generators part1
([#2952](#2952))
([1582a9f](1582a9f))
* Introduce assertions generators part2
([#2956](#2956))
([f715e8a](f715e8a))
* network policy v1 readiness
([#2914](#2914))
([3408c3f](3408c3f))
* Rework schema datasource
([#2954](#2954))
([f70e40e](f70e40e))
* Rework schema resource
([#2955](#2955))
([400a5c8](400a5c8))
* Role v1 readiness
([#2916](#2916))
([32c7690](32c7690))
* Schema SDK upgrade
([#2945](#2945))
([bca0836](bca0836))
* Streamlit v1 readiness
([#2930](#2930))
([aa42260](aa42260))


### 🔧 **Misc**

* Remove deprecation from unsafe execute
([#2941](#2941))
([ed712d7](ed712d7))
* Update documentation
([#2931](#2931))
([da98bc3](da98bc3))


### 🐛 **Bug fixes:**

* ATTRIBUTE set(string) parsing for cortex search service
([#2953](#2953))
([70a1c9a](70a1c9a))
* external function header parsing and add missing privileges
([#2961](#2961))
([9d882fe](9d882fe))
* Fix sync_password field for Azure scim clients
([#2950](#2950))
([6781133](6781133))
* Fix tests and relax warehouse validations
([#2959](#2959))
([dd01ce9](dd01ce9)),
closes
[#2948](#2948)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants