Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Streamlit v1 readiness #2930

Merged
merged 18 commits into from
Jul 22, 2024
Merged

feat: Streamlit v1 readiness #2930

merged 18 commits into from
Jul 22, 2024

Conversation

sfc-gh-jmichalak
Copy link
Collaborator

This PR adds streamlits datasource and streamlit resource. SDK is adjusted.

Test Plan

  • acceptance tests

References

https://docs.snowflake.com/en/sql-reference/sql/create-streamlit

@github-actions GitHub Actions
Copy link

Integration tests failure for 8ad8389a43f5ab76016cb3cf257cb9d66ec09585

@sfc-gh-jmichalak sfc-gh-jmichalak marked this pull request as ready for review July 11, 2024 13:22
@github-actions GitHub Actions
Copy link

Integration tests failure for bc64f85077956b529fad5b6b080556cf5976433f

@github-actions GitHub Actions
Copy link

Integration tests failure for 6539a38a57830cc88fa74983029793ed864d95bf

sfc-gh-jcieslak
sfc-gh-jcieslak requested changes Jul 14, 2024
View reviewed changes
pkg/datasources/streamlits.go Show resolved Hide resolved
pkg/datasources/streamlits_acceptance_test.go Outdated Show resolved Hide resolved
pkg/datasources/streamlits_acceptance_test.go Outdated Show resolved Hide resolved
pkg/datasources/streamlits_acceptance_test.go Outdated Show resolved Hide resolved
pkg/datasources/streamlits_acceptance_test.go Outdated Show resolved Hide resolved
pkg/resources/streamlit.go Outdated Show resolved Hide resolved
pkg/resources/streamlit_acceptance_test.go Show resolved Hide resolved
pkg/resources/streamlit_acceptance_test.go Outdated Show resolved Hide resolved
pkg/resources/diff_suppressions.go Outdated Show resolved Hide resolved
pkg/schemas/streamlit.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Integration tests failure for 14a7534cbf7f5f920a7ba4a581dba9dc7f92cebc

@github-actions GitHub Actions
Copy link

Integration tests failure for 35f901ab7cbe11d3fb8b27a7a2ef45de5be1ab4e

@github-actions GitHub Actions
Copy link

Integration tests failure for bc9b60eb9e8899bda9ff67172971f0e1567170ba

sfc-gh-asawicki
sfc-gh-asawicki requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the next PRs into parts (at least SDK, resource, datasource)

MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
docs/data-sources/streamlits.md Outdated Show resolved Hide resolved
docs/resources/streamlit.md Outdated Show resolved Hide resolved
docs/resources/streamlit.md Show resolved Hide resolved
pkg/acceptance/helpers/external_access_integration_client.go Show resolved Hide resolved
pkg/resources/streamlit.go Outdated Show resolved Hide resolved
pkg/resources/streamlit.go Outdated Show resolved Hide resolved
pkg/resources/streamlit_acceptance_test.go Outdated Show resolved Hide resolved
pkg/resources/streamlit_acceptance_test.go Show resolved Hide resolved
pkg/resources/streamlit_acceptance_test.go Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Integration tests failure for 27798708bbed7d2fb5a2c5484295d9f805e7d45a

@github-actions GitHub Actions
Copy link

Integration tests failure for 34412cdc04d121cea5949bb8881dfc002ecc0df3

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review July 18, 2024 12:39
sfc-gh-asawicki
sfc-gh-asawicki previously approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but please check the two failing tests

@github-actions GitHub Actions
Copy link

Integration tests failure for a0b9d44351be619be37ac3737adcdae3e2064841

1 similar comment
@github-actions GitHub Actions
Copy link

Integration tests failure for a0b9d44351be619be37ac3737adcdae3e2064841

@github-actions GitHub Actions
Copy link

Integration tests failure for 32bbd599e0f3217b2d4dcc805bece159b8dbfb39

@github-actions GitHub Actions
Copy link

Integration tests failure for 7c6225ddb79f535620211963ae3fbee2a0395538

@github-actions GitHub Actions
Copy link

Integration tests failure for dc75b564cf4deec8bc0564dda7213db342a9aa05

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review July 22, 2024 09:50
@github-actions GitHub Actions
Copy link

Integration tests failure for 118cc49fe9356f403f845814361891aa8234e30d

@sfc-gh-jmichalak sfc-gh-jmichalak merged commit aa42260 into main Jul 22, 2024
8 of 9 checks passed
@sfc-gh-jmichalak sfc-gh-jmichalak deleted the streamlit-v1 branch July 22, 2024 11:41
@snowflake-release-please snowflake-release-please bot mentioned this pull request Jul 22, 2024
Merged
sfc-gh-jcieslak pushed a commit that referenced this pull request Jul 26, 2024
@snowflake-release-please
chore(main): release 0.94.0 (#2933)
f6064af 
🤖 I have created a release *beep* *boop*
---


##
[0.94.0](v0.93.0...v0.94.0)
(2024-07-26)


### 🎉 **What's new:**

* Add missing session parameters
([#2936](#2936))
([4ce662d](4ce662d))
* Adjust user SDK
([#2947](#2947))
([1127bb3](1127bb3))
* Better tests poc
([#2917](#2917))
([ef496c2](ef496c2))
* Introduce assertions generators part1
([#2952](#2952))
([1582a9f](1582a9f))
* Introduce assertions generators part2
([#2956](#2956))
([f715e8a](f715e8a))
* network policy v1 readiness
([#2914](#2914))
([3408c3f](3408c3f))
* Rework schema datasource
([#2954](#2954))
([f70e40e](f70e40e))
* Rework schema resource
([#2955](#2955))
([400a5c8](400a5c8))
* Role v1 readiness
([#2916](#2916))
([32c7690](32c7690))
* Schema SDK upgrade
([#2945](#2945))
([bca0836](bca0836))
* Streamlit v1 readiness
([#2930](#2930))
([aa42260](aa42260))


### 🔧 **Misc**

* Remove deprecation from unsafe execute
([#2941](#2941))
([ed712d7](ed712d7))
* Update documentation
([#2931](#2931))
([da98bc3](da98bc3))


### 🐛 **Bug fixes:**

* ATTRIBUTE set(string) parsing for cortex search service
([#2953](#2953))
([70a1c9a](70a1c9a))
* external function header parsing and add missing privileges
([#2961](#2961))
([9d882fe](9d882fe))
* Fix sync_password field for Azure scim clients
([#2950](#2950))
([6781133](6781133))
* Fix tests and relax warehouse validations
([#2959](#2959))
([dd01ce9](dd01ce9)),
closes
[#2948](#2948)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jmichalak @sfc-gh-jcieslak @sfc-gh-asawicki