feat: [PoC] Set up integration tests - with setup #1989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1 task
|
Integration tests failure for 9a42a280629572d81c0aab14ee63e2bcfea50e53 |
1 similar comment
|
Integration tests failure for 9a42a280629572d81c0aab14ee63e2bcfea50e53 |
sfc-gh-asawicki
force-pushed
the
poc-it-with-setup
branch
from
9a42a28
to
e3ffec4
Compare
|
Integration tests success for e3ffec4f0bf17f471a71fdfe0d99913b1f3c22e9 |
sfc-gh-asawicki
force-pushed
the
poc-it-with-setup
branch
from
e3ffec4
to
27de15c
Compare
|
Integration tests success for 27de15c23e71ba2d37e0b3f83115cc278a70b30b |
sfc-gh-asawicki
force-pushed
the
poc-it-with-setup
branch
from
27de15c
to
1f72f3a
Compare
|
Integration tests failure for 1f72f3a0c26c47380c9beeb7b6b117532e56211e |
# Conflicts: # pkg/sdk/pipes_integration_test.go
sfc-gh-asawicki
force-pushed
the
poc-it-with-setup
branch
from
1f72f3a
to
0adbd9c
Compare
|
Integration tests success for 0adbd9c303766e92642b6d8c8810649ae5235b94 |
|
This was just a PoC. Continuation in #2111. |
This was referenced Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a short PoC of introducing TestMain wrapper to all integration tests to avoid common setup and cleanup (with the aim to reduce boilerplate and tests time).
There are two PRs:
On local machine the difference in running example test was around 20% time reduction (accordingly without and with set up):
Test Plan