feat: supports collation of table column #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @YAhiru. Thank you for the pull request, we will analyze and review it this week. |
sfc-gh-jcieslak
requested changes
Feb 16, 2024
There was a problem hiding this comment.
Thanks for the contribution! I had some small remarks, but other than that everything looks good. I would like @sfc-gh-asawicki to look at the change since he has more experience with the table resource.
sfc-gh-jcieslak
previously approved these changes
Feb 20, 2024
sfc-gh-asawicki
approved these changes
Feb 20, 2024
sfc-gh-asawicki
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Good change, have just one small comment. Thanks for the contribution @YAhiru. I will also run the tests on it, to validate the correctness.
|
/ok-to-test sha=931dc0abdfad06d9cc3bb1781b7ae353dcab0f84 |
|
Integration tests failure for 931dc0abdfad06d9cc3bb1781b7ae353dcab0f84 |
1 similar comment
|
Integration tests failure for 931dc0abdfad06d9cc3bb1781b7ae353dcab0f84 |
|
/ok-to-test sha=1ba35b07682bc2fb89b71c33eaebff9e36b8eeea |
|
Integration tests failure for 1ba35b07682bc2fb89b71c33eaebff9e36b8eeea |
sfc-gh-asawicki
approved these changes
Feb 20, 2024
|
I have merged it. Thanks for the contribution one more time @YAhiru! |
|
@sfc-gh-jcieslak @sfc-gh-asawicki |
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Feb 28, 2024
🤖 I have created a release *beep* *boop* --- ## [0.87.0](v0.86.0...v0.87.0) (2024-02-28) ### 🎉 **What's new:** * Add network rule to the sdk ([#2526](#2526)) ([b379565](b379565)) * supports collation of table column ([#2496](#2496)) ([56771f1](56771f1)) ### 🔧 **Misc** * Clean up environment variables in tests and on CI ([#2543](#2543)) ([9a10cb1](9a10cb1)) * replace warning in new grant resources with info log ([#2521](#2521)) ([c3014b9](c3014b9)) ### 🐛 **Bug fixes:** * data retention days follow up ([#2566](#2566)) ([7aba384](7aba384)) * data retention time parameters ([#2502](#2502)) ([76abf21](76abf21)) * data retention time parameters follow-up ([#2530](#2530)) ([5544544](5544544)) * Demote warning to info and set volatility for procedures and functions ([#2567](#2567)) ([abaad7c](abaad7c)), closes [#2536](#2536) * Fix ACCOUNT PARAMETERS option failover group resource ([#2522](#2522)) ([61883f3](61883f3)), closes [#2517](#2517) * Fix failover group alter syntax and suppression for pipe statement ([#2562](#2562)) ([24d76c3](24d76c3)) * Fix few tests ([#2515](#2515)) ([a523a6b](a523a6b)) * Fix provider config hierarchy ([#2551](#2551)) ([677a12b](677a12b)) * Fix query_results in unsafe_execute resource ([#2512](#2512)) ([94ca158](94ca158)), closes [#2491](#2491) * Fix replication for database resource ([#2524](#2524)) ([767fbce](767fbce)), closes [#2021](#2021) * Fix show by id for external functions ([#2531](#2531)) ([d910a84](d910a84)), closes [#2528](#2528) * Fix various small problems ([#2552](#2552)) ([f558ce6](f558ce6)) * Granting database roles ([#2511](#2511)) ([dc27d64](dc27d64)), closes [#2402](#2402) * grants on external volumes ([#2538](#2538)) ([1de9a29](1de9a29)) * Handle old reference for table_id in table constraint resource ([#2558](#2558)) ([d1e8912](d1e8912)), closes [#2535](#2535) * loosen identifier field validation for account object identifiers ([#2564](#2564)) ([a5ed8cd](a5ed8cd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the collation attribute of the table column to the table resource.
please let me know if there is any code that does not follow the convention 🙏
Test Plan
References