chore: Replace id generation in integration and acceptance tests part1 #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for 1c63c7df64bb6830486409a38f34026ed885c76b |
…eptance tests with exceptions (WIP - still a few TODOs left)
Exceptions:
- testAccCheckDatabaseExistence
- grantOwnershipToTheCurrentRole
- testAccCheckSharePrivilegesRevoked
- sdk.NewAccountObjectIdentifier("ACCOUNTADMIN")
- sdk.NewAccountObjectIdentifier("ORGADMIN")
- sdk.NewAccountObjectIdentifier("NOT_EXISTING_ACCOUNT")
- sdk.NewAccountObjectIdentifier("does_not_exist")
- current role/user
- sdk.NewAccountObjectIdentifier("<DB>")
sfc-gh-asawicki
force-pushed
the
replace-id-generation-in-acceptance-tests-part1
branch
from
1c63c7d
to
ebe54c3
Compare
…in integration and acceptance tests
|
Integration tests failure for ebe54c3b4b17747c3c9e24d407fa0845e1d6ea34 |
sfc-gh-asawicki
changed the title
|
Integration tests failure for 8a0b0df1c73af42709d3be0ed0c0e7c293fe307d |
sfc-gh-jcieslak
previously approved these changes
Apr 29, 2024
sfc-gh-jcieslak
approved these changes
Apr 29, 2024
|
Integration tests failure for e364be6ae736a176c31a7b4939409f3c242a4eb6 |
sfc-gh-asawicki
deleted the
replace-id-generation-in-acceptance-tests-part1
branch
sfc-gh-asawicki
added a commit
that referenced
this pull request
May 20, 2024
Continuation of #2747 (topics connected with `NewAccountObjectIdentifier`): - `alterMaterializedViewQueryExternally` - moved to test helper - `checkDatabaseAndSchemaDataRetentionTime` - id part reworked, method left for assertions introduction - `checkDatabaseSchemaAndTableDataRetentionTime` - id part reworked, method left for assertions introduction - `unsafe_execute_acceptance_test.go` - id part reworked, some methods left for assertions introduction - `alterViewOwnershipExternally` - moved to test helper - check `app_role_1` - test role name extracted and parametrized in tests - check hardcoded `filter_by_role`, `stproc1`, `sp_pi`, `filterByRole`, `records` - added to procedure rework - ask @sfc-gh-jcieslak about `sdk.NewAccountObjectIdentifier("S3_STORAGE_INTEGRATION")`, `sdk.NewAccountObjectIdentifier("GCP_STORAGE_INTEGRATION")`, `sdk.NewAccountObjectIdentifier("AZURE_STORAGE_INTEGRATION")` - precreated integrations extracted - extract common helpers for `sdk.NewAccountObjectIdentifier("does_not_exist")` and similar - extracted - Fixed setup for multiple acceptance tests (to use random ids not random strings) Still left (connected with `NewAccountObjectIdentifier`): - `CreateDatabaseWithName` (and other similar helpers) - check `setup_test.go` Additional changes: - changed return type for `CurrentRole` and `CurrentUser` to ids - Fixed ShowByID for application roles - Added FAQ entry about possible identifier error - Introduced `DatabaseId()` and `SchemaId()` helpers to identifiers and convenience methods to use them - Introduced some additional placeholders (like role ids for ACCOUNTADMIN and ORGADMIN) - Moved check destroy to a common place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to move to the unified ID generation (connected with the changes in #2737) to stabilize parallel builds, the following changes were introduced inside this PR:
TestAcc_TaskOwnershipGrant_onFuturetestLeft to be done regarding NewAccountObjectIdentifier:
alterMaterializedViewQueryExternallycheckDatabaseAndSchemaDataRetentionTimecheckDatabaseSchemaAndTableDataRetentionTimeunsafe_execute_acceptance_test.goalterViewOwnershipExternallyapp_role_1filter_by_role,stproc1,sp_pi,filterByRole,recordsCreateDatabaseWithName(and other similar helpers)setup_test.gosdk.NewAccountObjectIdentifier("S3_STORAGE_INTEGRATION"),sdk.NewAccountObjectIdentifier("GCP_STORAGE_INTEGRATION"),sdk.NewAccountObjectIdentifier("AZURE_STORAGE_INTEGRATION")sdk.NewAccountObjectIdentifier("does_not_exist"and similar