Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle all Task parameters in SDK #3103

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

Changes

  • Picked which parameters should be used in tasks (internal doc).
  • Generated parameter asserts and used them in integration tests.
  • Minor change in assertion generating template (it was failing in my case because it was creating single letter variable which was t in this case and it conflicted with parameter t).

Copy link

Integration tests failure for 324d025048c84550f48d458a8bf7c5744a59c5e0

@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review September 24, 2024 12:31
Copy link

Integration tests failure for d8583e6af3bc2f8995b0004f188358397fd933ad

Copy link

Integration tests failure for 74ca1b9f24d40ad6dbedf0d6d30edb9e5d7b9c37

Copy link

Integration tests failure for f486fc912e287705c1ba519339980cf4009f5592

Copy link

Integration tests failure for ef185a7c6673bf72eafd8d1955887add79638c69

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 08ae072 into main Sep 30, 2024
8 of 9 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the tasks-sdk-parameters branch September 30, 2024 08:58
sfc-gh-jcieslak pushed a commit that referenced this pull request Oct 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.97.0](v0.96.0...v0.97.0)
(2024-10-10)


### 🎉 **What's new:**

* Add secret to sdk
([#3091](#3091))
([7430aee](7430aee))
* Add service user and legacy service user resources
([#3119](#3119))
([0e88e08](0e88e08))
* Handle all Task parameters in SDK
([#3103](#3103))
([08ae072](08ae072))
* Stream on external table resource
([#3122](#3122))
([d837341](d837341))
* Stream on table resource
([#3109](#3109))
([97fa9b4](97fa9b4))
* Tasks v1 readiness - SDK part
([#3086](#3086))
([0a77383](0a77383))
* Upgrade stream sdk
([#3105](#3105))
([ad5fa11](ad5fa11))


### 🔧 **Misc**

* Add pre check to each datasource
([#3065](#3065))
([560ab6b](560ab6b))
* Bump golang-ci lint to 1.61
([#3112](#3112))
([f23e085](f23e085))
* Secret Validation change
([#3111](#3111))
([666630e](666630e))


### 🐛 **Bug fixes:**

* Fix parsing text in view, check parenthesis in
ParseSchemaObjectIdentifierWithArguments
([#3102](#3102))
([b0a67e6](b0a67e6))
* Try to reproduce 2679 and 3117
([#3124](#3124))
([ccdbc30](ccdbc30))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants