Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync beefy commitment on demand #1217

Merged

Conversation

yrong
Copy link
Contributor

@yrong yrong commented May 31, 2024

A one-shot relayer at this moment and how we would integrate the one-shot relayer in future as follows from @vgeddes:

  1. User on Polkadot signals that they want to speed up their message by depositing a fee in a special account on AssetHub/BridgeHub
  2. An offchain service witnesses that deposit, and invokes the one-shot relayer

relayer/cmd/sync_beefy_commitment.go Outdated Show resolved Hide resolved
relayer/cmd/sync_beefy_commitment.go Outdated Show resolved Hide resolved
relayer/cmd/sync_beefy_commitment.go Outdated Show resolved Hide resolved
@vgeddes
Copy link
Collaborator

vgeddes commented May 31, 2024

Still need to adjust for the change in parameters.go: https://github.com/Snowfork/snowbridge/pull/1216/files#diff-e3b26e6a7128d75b5212e1dcbf97eb9f68934a321bd0d45990894a40f2b7cc24L168

Only submissions for mandatory commitments need to include an MMR leaf and proof. The one-shot relay doesn't need to include those.

@yrong
Copy link
Contributor Author

yrong commented Jun 3, 2024

Only submissions for mandatory commitments need to include an MMR leaf and proof. The one-shot relay doesn't need to include those.

I'd prefer to include the MMR leaf and proof for the oneshot case, vaguely recalled it won't cost much to add these to calldata without validation. The benefit is that it's possible to use the oneshot command for even sync the mandatory commitments.

@yrong yrong marked this pull request as ready for review June 3, 2024 08:22
@vgeddes vgeddes merged commit 95845a3 into vincent/beefy-relay-improvements Jun 3, 2024
1 check passed
@vgeddes vgeddes deleted the ron/beefy-relay-improvements branch June 3, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants