Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lodestar 1.4.2 update #771

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Lodestar 1.4.2 update #771

merged 3 commits into from
Feb 8, 2023

Conversation

claravanstaden
Copy link
Contributor

Lodestar upgrade. Blocked by an issue where the finalized_header is empty for sync committee updates.

@claravanstaden claravanstaden changed the title Starts with lodestar updates. Lodestar 1.4.0 update Feb 4, 2023
@claravanstaden
Copy link
Contributor Author

Fixed by ChainSafe/lodestar#5090. Waiting for Lodestar release 1.4.2 to include the fix.

@yrong
Copy link
Contributor

yrong commented Feb 5, 2023 •
edited
Loading

@claravanstaden one issue I met maybe also worth to mention here.

would assume the pr in 1.4.1 also related to the weird issue we met before in some mac os. hope with it no need to hack in /etc/hosts or explicitly adding 127.0.0.1 any more.

@claravanstaden claravanstaden changed the title Lodestar 1.4.0 update Lodestar 1.4.2 update Feb 8, 2023
@claravanstaden claravanstaden marked this pull request as ready for review February 8, 2023 07:59
@claravanstaden
Copy link
Contributor Author

claravanstaden commented Feb 8, 2023 •
edited
Loading

would assume the ChainSafe/lodestar#5073 in 1.4.1 also related to the weird issue we met before in some mac os. hope with it no need to hack in /etc/hosts or explicitly adding 127.0.0.1 any more.

@yrong is this still an issue for you on lodestar 1.4.2? Edit: Looks like it is solved in 1.4.1 but you can perhaps retest and confirm.

alistair-singh
alistair-singh approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@claravanstaden
Copy link
Contributor Author

I'm going to merge this now because I would like to rebase my ancestry proof branch. I'll address any follow-up comments in a separate PR, if necessary.

@claravanstaden claravanstaden merged commit 0d67306 into main Feb 8, 2023
@claravanstaden claravanstaden deleted the clara/upgrade-lodestar-v1.4.0 branch February 8, 2023 09:58
@yrong yrong mentioned this pull request Feb 10, 2023
Merged
3 tasks
@yrong
Copy link
Contributor

yrong commented Feb 10, 2023 •
edited
Loading

is this still an issue for you on lodestar 1.4.2? Edit: Looks like it is solved in 1.4.1 but you can perhaps retest and confirm.

Sorry for the late response and yes it works in my setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair-singh alistair-singh alistair-singh approved these changes

@doubledup doubledup Awaiting requested review from doubledup

@vgeddes vgeddes Awaiting requested review from vgeddes

@yrong yrong Awaiting requested review from yrong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@claravanstaden @yrong @alistair-singh