Create Block, BlockCategory enums. Create block state struct. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kralverde
force-pushed
the
block_id_tweaks
branch
from
51fae3b
to
b7b975a
Compare
|
There where discussions in the Discord about an Large Blocks Enum, Like @lukas0008 once did. The Problem was compile time. I generally would really like a big enum with all blocks the game has, This would be also a more error safe approche |
|
I think the issue was creating an enum for every single possible state. This just has blocks and categories. Try it out, I don't think compile time is that bad. |
|
Is this ready for merge ? |
|
Unless anyone finds issue with it it's ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements enums for Block and BlockCategories via macro which will be necessary for terrain gen. Additionally adds a BlockState struct to include these enums.