Add kill command #107
Merged
Add kill command #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, Thanks for the PR :D. I currently did not implemented respawning, thats the reason the Player is proberbly stuck. Btw you forgot to format thats the reason CI is mad. |
|
Perfect, I've just formatted the code, thank you for the advice! |
Snowiiii
reviewed
Oct 1, 2024
pumpkin/src/commands/cmd_kill.rs
Outdated
Comment on lines
22
to
24
| target.send_system_message( | ||
| TextComponent::text("You have been killed.").color_named(NamedColor::Red), | ||
| ); |
There was a problem hiding this comment.
Vanilla does not send a message to the killed target. We also should not
|
Ok ,done. I confused and written kick instead of kill but only on the name of the commit. |
|
Looks good to me then. We should definitely add support for killing entites as well not only players in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the /kill command to the server. However, it only makes the sound, shows the particles and the player can't move anymore instead of properly dying. This happens because the command calls the kill function on entity/mod.rs which only does that.