-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added /playsound command (missing minVolume) #282
base: master
Are you sure you want to change the base?
Conversation
|
No, I moved the Sound data stuctures from
Yes, my bad, I forgot a word, I added them to several structs to make everyone able to debug theses structs.
The playsound command only miss the minVolume argument. As I'm not sure if I will be able to work more on it for the next days I submitted it. The command can already be used but it just miss this part. I will try to split the command, the debug trait add and the move of sound structures to different PR |
So, Why you added a bunch of Debug's ? |
I had to add them to debug and understand how the command dispatcher was working. It was a bit painful to add them everywhere in the code so I figured I will left them here to make it easier for the next person that wants to debug For the Sound data structs move to core should I open another PR ? It's a really small change and is directly related to the command. |
Took 4 hours 15 minutes Took 5 minutes Took 14 minutes
The default value for the existing World::play_sound calls is 1.0 for volume and pitch. Took 7 minutes
…to pumpkin-core and added a parser for the several sound categories Took 2 hours 15 minutes Took 1 minute
Took 6 hours 12 minutes Took 32 seconds
…used in playsound command and others
…minVolume use) Took 55 seconds
…e missing it Took 18 seconds
…ound struct fields public Took 1 hour 56 minutes
Took 25 seconds
…d obsolete types Took 3 minutes
15885eb
to
4d8021b
Compare
This is not a good way to debug things. You basically just added them EVERYWHERE. at this point im wondering if you even read the code or just working out of your terminal and can only see what the Debug traits prints.
I don't know. I did not look at your Code because i don't want to search actual code trough all the 43 Changed files. If you need it for the /playsound command it only makes sense to have them in the same PR |
Description
This PR adds a first incomplete implementation of the playsound command (the minVolume is just ignored and not used for the moment).
It also adds the Debug trait on an amount of data structures
And finally it moves the sound data structure from pumpkin-macros to pumpkin-core
Testing
The command has been tested functionnaly in game with various inputs.
Checklist
Things need to be done before this Pull Request can be merged.
cargo fmt
cargo clippy