Configure eslint and fix few warnings

Socolin · Apr 1, 2024 · 16db99e · 16db99e
1 parent 5bf57ae
commit 16db99e
Show file tree

Hide file tree

Showing 51 changed files with 448 additions and 191 deletions.
diff --git a/frontend/.eslintrc.json b/frontend/.eslintrc.json
@@ -8,29 +8,27 @@
         "*.ts"
       ],
       "parserOptions": {
-        "project": [
-          "tsconfig.json"
-        ],
         "createDefaultProgram": true
       },
       "extends": [
         "plugin:@angular-eslint/recommended",
         "plugin:@angular-eslint/template/process-inline-templates"
       ],
       "rules": {
+        "@angular-eslint/no-empty-lifecycle-method": 0,
         "@angular-eslint/directive-selector": [
-          "error",
+          "off",
           {
             "type": "attribute",
-            "prefix": "admin",
+            "prefix": "app",
             "style": "camelCase"
           }
         ],
         "@angular-eslint/component-selector": [
-          "error",
+          "off",
           {
             "type": "element",
-            "prefix": "admin",
+            "prefix": "app",
             "style": "kebab-case"
           }
         ]

diff --git a/frontend/angular.json b/frontend/angular.json
@@ -124,12 +124,12 @@
           }
         },
         "lint": {
-          "builder": "@angular-devkit/build-angular:tslint",
+          "builder": "@angular-eslint/builder:lint",
           "options": {
-            "tsConfig": [
-              "src/tsconfig.json"
-            ],
-            "exclude": ["**/node_modules/**"]
+              "lintFilePatterns": [
+                  "src/**/*.ts",
+                  "src/**/*.html"
+              ]
           }
         }
       }
@@ -147,6 +147,9 @@
     }
   },
   "cli": {
-    "analytics": false
+    "analytics": false,
+      "schematicCollections": [
+          "@angular-eslint/schematics"
+      ]
   }
 }
diff --git a/frontend/package-lock.json b/frontend/package-lock.json
diff --git a/frontend/package.json b/frontend/package.json
@@ -7,7 +7,7 @@
     "ng": "ng",
     "start": "ng serve",
     "start:windows": "ng serve --host 0.0.0.0",
-    "lint": "eslint \"src/**/*.ts\"",
+    "lint": "ng lint",
     "test": "ng test",
     "build": "node --max_old_space_size=16384 ./node_modules/@angular/cli/bin/ng build --configuration production",
     "pree2e": "webdriver-manager update --standalone false --gecko false",
@@ -55,6 +55,8 @@
     "@types/jasmine": "~3.6.2",
     "@types/node": "^18.19.28",
     "@types/leaflet": "^1.5.19",
+    "@typescript-eslint/eslint-plugin": "7.4.0",
+    "@typescript-eslint/parser": "7.4.0",
     "eslint": "^8.57.0",
     "jasmine-core": "~5.1.2",
     "jasmine-spec-reporter": "~7.0.0",

diff --git a/frontend/src/app/action/nhbk-action-editor-dialog.component.html b/frontend/src/app/action/nhbk-action-editor-dialog.component.html
@@ -13,7 +13,7 @@ <h2 mat-dialog-title>Ajouter une action</h2>
         <ng-template [ngSwitchCase]="'addItem'">
             <autocomplete-input [clearOnSelect]="false"
                                 [placeholder]="'Objet'"
-                                (onSelect)="selectItemTemplate($event)"
+                                (selected)="selectItemTemplate($event)"
                                 [callback]="autocompleteItemCallback">
             </autocomplete-input>
             <div *ngIf="selectedItemTemplate?.data?.quantifiable">
@@ -59,7 +59,7 @@ <h2 mat-dialog-title>Ajouter une action</h2>
             </stats-modifier-editor>
         </ng-template>
         <ng-template [ngSwitchCase]="'addEffect'">
-            <active-effect-editor [reusableToggle]="false" (onChange)="updateEffect($event)">
+            <active-effect-editor [reusableToggle]="false" (changed)="updateEffect($event)">
             </active-effect-editor>
         </ng-template>
         <ng-template ngSwitchDefault>

diff --git a/frontend/src/app/app.component.spec.ts b/frontend/src/app/app.component.spec.ts
@@ -1,7 +1,5 @@
-/* tslint:disable:no-unused-variable */
-
-import { TestBed, async } from '@angular/core/testing';
-import { AppComponent } from './app.component';
+import {async, TestBed} from '@angular/core/testing';
+import {AppComponent} from './app.component';
 
 describe('AppComponent', () => {
   beforeEach(() => {

diff --git a/frontend/src/app/character/add-item-dialog.component.html b/frontend/src/app/character/add-item-dialog.component.html
@@ -21,7 +21,7 @@
                         <div class="category mat-caption">{{result.sectionName}} - {{result.subCategoryName}}</div>
                     </div>
                 </button>
-                <button disabled *ngIf="filteredItemTemplates && filteredItemTemplates.length == 0">
+                <button disabled *ngIf="filteredItemTemplates && filteredItemTemplates.length === 0">
                     Aucun objet trouvé
                 </button>
             </mat-action-list>