-
-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Overhang Printable #1615
Make Overhang Printable #1615
Conversation
* Added an Advanced setting to the Quality menu for Make overhang printable * Allow toggling the feature and adjusting the angle threshold
…able" is turned on
which fixs the `lslices` not being updated issue and also the elephant foot compensation
…ers won't clear caches properly. 2. Tweak the logic of make_overhang_printable parameter so that it works for per region/object/print level. Remove make_overhang_printable_disable parameter.
The PR looks to be in good shape.
Please review and test these changes. If everything looks good, we're good to merge it. 👍 |
With the change of the settings logic, now you can enable this setting on a single object without enabling the global one, however it won't be affective because of https://github.com/SoftFever/OrcaSlicer/pull/1615/files#diff-ae94698c496da8738c4a6413f08caa1e42aa965ba9de3960207d41943816df9fR1179-R1181 which makes this a bit confusing: |
2. Handle make_overhang_printable_angle and make_overhang_printable_hole_size value change
Agreed. |
LGTM |
I have not tested a later build, but my brother had mentioned the early ones seemed to mark the interior as 'bridging' and so prints would take a lot longer, in some cases twice as long. Was this fixed or changed with some of the logic changes? Otherwise I can try testing it again to narrow down the issue. |
I think that's the same issue as #1556 (comment) which should have been fixed. |
Great! I'm going to merge this PR. |
This replaces PR #1556