Remove type

Softcatala · Aug 11, 2023 · ed4bd4d · ed4bd4d
1 parent d877768
commit ed4bd4d
Show file tree

Hide file tree

Showing 8 changed files with 1 addition and 10 deletions.
diff --git a/cfg/projects/Dolibarr.json b/cfg/projects/Dolibarr.json
@@ -8,7 +8,6 @@
             "type": "transifex",
             "po_preprocessing" : "remove_untranslated",
             "conversor_setup": {
-                "type"       : "string",
                 "verb"       : "add",
                 "command"    : " --encoding=utf-8"
             }

diff --git a/cfg/projects/LanguageTool.json b/cfg/projects/LanguageTool.json
@@ -9,7 +9,6 @@
             "type": "transifex",
             "po_preprocessing" : "remove_untranslated",
             "conversor_setup": {
-                "type"       : "string",
                 "verb"       : "add",
                 "command"    : " --encoding=utf-8"
             }

diff --git a/cfg/projects/Tor.json b/cfg/projects/Tor.json
@@ -7,7 +7,6 @@
             "url": "https://app.transifex.com/otf/torproject",
             "type": "transifex",
             "conversor_setup": {
-                "type"       : "string",
                 "verb"       : "add",
                 "command"    : " --encoding=utf-8"
             }

diff --git a/cfg/projects/Zotero.json b/cfg/projects/Zotero.json
@@ -7,7 +7,6 @@
             "url": "https://app.transifex.com/zotero/zotero",
             "type": "transifex",
             "conversor_setup": {
-                "type"       : "string",
                 "verb"       : "add",
                 "command"    : " --encoding=utf-8"
             }

diff --git a/cfg/projects/mucommander.json b/cfg/projects/mucommander.json
@@ -7,7 +7,6 @@
             "url": "https://github.com/mucommander/mucommander",
             "type": "git",
             "conversor_setup": {
-                "type"       : "string",
                 "verb"       : "add",
                 "command"    : " --encoding=utf-8"
             }

diff --git a/src/builder/jsonbackend.py b/src/builder/jsonbackend.py
@@ -108,9 +108,7 @@ def _process_conversor(self, fileset, conversor_values):
         conversor_setup = ConversorSetupDTO()
 
         for properties_attr, properties_value in conversor_values.items():
-            if properties_attr == "type":
-                conversor_setup.type = properties_value
-            elif properties_attr == "verb":
+            if properties_attr == "verb":
                 conversor_setup.verb = properties_value
             elif properties_attr == "command":
                 conversor_setup.command = properties_value

diff --git a/src/tests/builder-tests/data/projects/testjsonbackend-mozilla.json b/src/tests/builder-tests/data/projects/testjsonbackend-mozilla.json
@@ -13,7 +13,6 @@
             "duplicates" : "msgctxt",
             "retrieval_pattern": "https://.*?/ca/.*?",
             "conversor_setup": {
-                "type"       : "string",
                 "verb"       : "add",
                 "command"    : " --encoding=utf-8"
             }

diff --git a/src/tests/builder-tests/testjsonbackend.py b/src/tests/builder-tests/testjsonbackend.py
@@ -34,7 +34,6 @@ def _validate_mozilla_project_mozilla_fileset(self, fileset):
         return
 
     def _validate_mozilla_project_conversor(self, conversor):
-        self.assertEquals(conversor.type, "string")
         self.assertEquals(conversor.verb, "add")
         self.assertEquals(conversor.command, " --encoding=utf-8")
         return