Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose functions previously in R/sysdata.rda #59

Closed
stufield opened this issue Aug 24, 2023 · 0 comments · Fixed by #60
Closed

Expose functions previously in R/sysdata.rda #59

stufield opened this issue Aug 24, 2023 · 0 comments · Fixed by #60

Comments

@stufield
Copy link
Contributor

  • once upon a time we wanted to hid these as internal functions
  • there is no good reason to keep doing this
  • move externals and allow full public access to internal code
stufield added a commit that referenced this issue Aug 25, 2023
@stufield
Remove sysdata.rda
2bf9b52 
- removing the internal sysdata.rda object
  and replacing those functions with actual `R/*.R` files
- there is no need to keep these internal functions hidden
- newly exported functions:
  - `addAttributes()`
  - `addClass()`
  - `cleanNames()`
  - `getAdatVersion()`
- new internal functions:
  - `convertColMeta()`
  - `genRowNames()`
  - `syncColMeta()`
  - `parseCheck()`
  - `scaleAnalytes()`
- `Makefile` no longer has recipe for generating sysdata.rda
- minor tweaks to some unit tests during porting over from
  internal code base
- fixes #59
@stufield stufield mentioned this issue Aug 25, 2023
Merged
stufield added a commit that referenced this issue Sep 8, 2023
@stufield
Remove sysdata.rda
647e65a 
- removing the internal sysdata.rda object
  and replacing those functions with actual `R/*.R` files
- there is no need to keep these internal functions hidden
- newly exported functions:
  - `addAttributes()`
  - `addClass()`
  - `cleanNames()`
  - `getAdatVersion()`
- new internal functions:
  - `convertColMeta()`
  - `genRowNames()`
  - `syncColMeta()`
  - `parseCheck()`
  - `scaleAnalytes()`
- `Makefile` no longer has recipe for generating sysdata.rda
- minor tweaks to some unit tests during porting over from
  internal code base
- fixes #59
@stufield stufield mentioned this issue Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove sysdata.rda internals and replace with user-friendly files SomaLogic/SomaDataIO
1 participant
@stufield